-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11-implemented-second-part-of-tests-Order-CartItem-User-ShoppingCart #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, with minor comments:
For integration testing Controllers and Repositories,
It would help if you used real DB with data instead of Mock classes and Mock answers
@ContextConfiguration(classes = {AuthControllerTest.class}) | ||
@ExtendWith(SpringExtension.class) | ||
@WebMvcTest(AuthControllerTest.class) | ||
class AuthControllerTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class AuthControllerTest { | |
class AuthControllerIntegrationTest { |
@ContextConfiguration(classes = {ShoppingCartControllerTest.class}) | ||
@ExtendWith(SpringExtension.class) | ||
@WebMvcTest(ShoppingCartControllerTest.class) | ||
class ShoppingCartControllerTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
||
@DataJpaTest | ||
@AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE) | ||
class OrderRepositoryTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class OrderRepositoryTest { | |
class OrderRepositoryIntegrationTest { |
|
||
@DataJpaTest | ||
@AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.AUTO_CONFIGURED) | ||
class ShoppingCartRepositoryTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class ShoppingCartRepositoryTest { | |
class ShoppingCartRepositoryIntegrationTest { |
Coverage screen : https://drive.google.com/file/d/1m5RL8nITxETX2qZhWtFzs8SJ6GGXcwZH/view?usp=share_link